[PATCH] D26884: Change setDiagnosticsOutputFile to take a unique_ptr from a raw pointer (NFC)

[Mehdi AMINI via llvm-commits]

mehdi_amini added a comment.

Pushed inadvertently with https://reviews.llvm.org/D26886, I'll address the review as post-commit.



================
Comment at: llvm/include/llvm/IR/LLVMContext.h:197
   /// set, the handler is invoked for each diagnostic message.
-  void setDiagnosticsOutputFile(yaml::Output *F);
+  void setDiagnosticsOutputFile(std::unique_ptr<yaml::Output> F);
 
----------------
malcolm.parsons wrote:
> Pass by value if always moving doesn't apply to move-only types. Use && to avoid a temporary.
Sorry I don't understand this comment?


Repository:
  rL LLVM

https://reviews.llvm.org/D26884