[PATCH] D26873: [LV] Do not vectorize loops with a low dynamic tripcount, as determined by profile information

Adam Nemet via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 18 16:16:49 PST 2016


anemet added inline comments.


================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:7203-7206
       ORE->emit(createMissedAnalysis(Hints.vectorizeAnalysisPassName(),
                                      "NotBeneficial", L)
                 << "vectorization is not beneficial "
                    "and is not explicitly forced");
----------------
While you're here, can you please improve this message to actually mention low-trip count?


================
Comment at: test/Transforms/LoopVectorize/X86/runtime-trip-count.ll:2
+; RUN: opt < %s  -loop-vectorize -force-vector-interleave=1 -force-vector-width=4 -S -debug-only=loop-vectorize 2>&1 | FileCheck %s
+; REQUIRES: asserts
+
----------------
We usually try to formulate these tests without relying on asserts so that we get coverage with a no-assert build as well.


https://reviews.llvm.org/D26873





More information about the llvm-commits mailing list