[PATCH] D26848: [PATCH] Reduce inline thresholds to compensate for cost changes

[Michael Zolotukhin via llvm-commits]

mzolotukhin added a comment.

Hi James,

Thanks for following up, a couple of questions inline.

Best regards,
Michael



================
Comment at: test/Transforms/Inline/ephemeral.ll:24
 ; CHECK-NOT: call i1 @inner
-define i1 @outer() optsize {
-   %r = call i1 @inner()
-   ret i1 %r
+define i32 @outer() optsize {
+   %r = call i32 @inner()
----------------
Why is this change needed?


================
Comment at: test/Transforms/Inline/inline-fp.ll:135-136
 
-attributes #0 = { minsize optsize }
-attributes #1 = { minsize optsize "use-soft-float"="true" }
+attributes #0 = { optsize }
+attributes #1 = { optsize "use-soft-float"="true" }
----------------
Is this one of the cases where we can not preserve the original behavior, or we intentionally want another one here (no context in the patch makes it harder to comprehend from here)?


Repository:
  rL LLVM

https://reviews.llvm.org/D26848