[PATCH] D25963: [LoopUnroll] Implement profile-based loop peeling

Michael Kuperstein via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 18 13:35:52 PST 2016


mkuper added a comment.

In https://reviews.llvm.org/D25963#600198, @danielcdh wrote:

> In https://reviews.llvm.org/D25963#600188, @mkuper wrote:
>
> > Rebased to resolve conflicts with r287186.
> >
> > Dehao, note I moved the flat loop check to be below the peeling computation, otherwise it would preempt it.
> >  I think as long as it's above runtime unrolling, it does what you meant, right?
>
>
> SGTM. Looks like the check becomes noop when peeling is enabled. But it would still serve as a backup plan when peeling is not enabled.


I don't think it's a noop. We may decide not to peel even with a low trip count, but we will still prefer not to unroll.


https://reviews.llvm.org/D25963





More information about the llvm-commits mailing list