[PATCH] D26848: [PATCH] Reduce inline thresholds to compensate for cost changes

Gerolf Hoflehner via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 18 10:50:43 PST 2016


> On Nov 18, 2016, at 9:20 AM, David Li <davidxl at google.com> wrote:
> 
> davidxl added inline comments.
> 
> 
> ================
> Comment at: include/llvm/Analysis/InlineCost.h:39
> /// Use when -O3 is specified.
> -const int OptAggressiveThreshold = 275;
> +const int OptAggressiveThreshold = 250;
> 
> ----------------
> Any reason to reduce O3 threshold?

Look at the compile time jumps of > 10% at http://lab.llvm.org:8080/green/view/Compile%20Time/ <http://lab.llvm.org:8080/green/view/Compile%20Time/>

When there is no significant performance benefit (measured on wide range of standard benchmark and apps) reducing the threshold is the sensitive approach. 

-Gerolf

> 
> Repository:
>  rL LLVM
> 
> https://reviews.llvm.org/D26848
> 
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161118/aa9435d4/attachment-0001.html>


More information about the llvm-commits mailing list