[PATCH] D26857: [ELF] Print output name for command line errors

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 18 10:42:35 PST 2016


On 18 November 2016 at 12:17, Eugene Leviant <eleviant at accesssoftek.com> wrote:
> evgeny777 added inline comments.
>
>
> ================
> Comment at: ELF/Driver.cpp:99
>      else
> -      error("unknown emulation: " + Emul);
> +      error(getOutputName() + ": unknown emulation: " + Emul);
>    }
> ----------------
> rafael wrote:
>> I am not sure it makes sense to always print the output name. In here the issue has nothing to do with the files, it is just a broken -m option.
>>
>> If you want a common format, maybe printing something like" <command line>:" in here would be better.
> So do you propose to use **<command line>** as tag for all command line arguments errors?

Something like it. It seems better to have tag like that (or no tag)
than to report a file name that has no connection with the error.

Cheers,
Rafael


More information about the llvm-commits mailing list