[PATCH] D26277: [SLP] Fixed cost model for horizontal reduction.

Alexey Bataev via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 18 09:46:54 PST 2016


ABataev added a comment.

In https://reviews.llvm.org/D26277#598814, @mkuper wrote:

> So, now, none of the costs on the tests actually change?
>  Does that mean that the changes in costs in the previous versions came from the +1?
>
> Can you add a test that demonstrates the cost change? (Preferably in a way that shows what happened - e.g. commit a test with the "bad" cost, and then have a diff with the good one).


Changed a code a little bit. Checked it, the calculated cost is very close to the real situation, but seems to me the BoUpSLP tree cost is too optimistic. Will look at it later.


https://reviews.llvm.org/D26277





More information about the llvm-commits mailing list