[PATCH] D26212: IRMover: Avoid accidentally mapping types from the destination module (PR30799)

[Hans Wennborg via llvm-commits]

hans added a subscriber: tstellarAMD.
hans added a comment.

In https://reviews.llvm.org/D26212#599346, @mehdi_amini wrote:

> Ping?
>
> I think this should go in 3.9.1, so it'd be great to land it ASAP.


Sorry, I got distracted by other stuff. Committing now.

As for 3.9.1, we should ask Tom (now cc'd) what he thinks.



================
Comment at: lib/Linker/IRMover.cpp:707
+      // getIdentifiedStructTypes() can have found it by walking debug info
+      // metadata nodes, some of which get linked by name, from the source to
+      // the destination module.
----------------
mehdi_amini wrote:
> `some of which get linked by name` add `when ODR Type Uniquing is enabled on the Context`
Done.


https://reviews.llvm.org/D26212