[PATCH] D26852: [ELF] Print archive name when it fails to parse
Eugene Leviant via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 18 08:27:50 PST 2016
evgeny777 added inline comments.
================
Comment at: ELF/Driver.cpp:119
if (Err)
- fatal("Archive::children failed: " + toString(std::move(Err)));
+ fatal(MB.getBufferIdentifier() + ": Archive::children failed: " +
+ toString(std::move(Err)));
----------------
grimar wrote:
> evgeny777 wrote:
> > grimar wrote:
> > > This looks was not covered by testcase, just like 2 messages above btw,
> > > also it has uppercase message while we usually do use lowercase always I believe.
> > Yep, but it wasn't covered originally as well and you have to use binary file to cover this.
> I see now. I think anyways we want to cover that. (I am ok to take this task). Anyways I think we are in position where *all* errors should ideally be covered with testcases. LLD is pretty solid now and we might want to think about user frienly messages and so on.
> Any objections ?
> Any objections ?
I don't have any.
Repository:
rL LLVM
https://reviews.llvm.org/D26852
More information about the llvm-commits
mailing list