[PATCH] D26725: AMDGPU: Add llvm.amdgcn.interp.mov intrinsic

[Nicolai Hähnle via llvm-commits]

nhaehnle added a comment.

LGTM



================
Comment at: include/llvm/IR/IntrinsicsAMDGPU.td:481
+            [llvm_i32_ty, llvm_i32_ty, llvm_i32_ty, llvm_i32_ty],
+            [IntrNoMem]>;
+
----------------
tstellarAMD wrote:
> arsenm wrote:
> > Shouldn't this be IntrReadMem? The doc says it reads parameters in LDS
> I think technically, this should be inaccessiblememonly,  because but there is no intrinsic attribute for this yet.
And that region of LDS is constant anyway, so IntrNoMem is fine.


https://reviews.llvm.org/D26725