[PATCH] D26852: [ELF] Print archive name when it fails to parse

Eugene Leviant via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 18 08:09:13 PST 2016


evgeny777 added inline comments.


================
Comment at: ELF/Driver.cpp:119
   if (Err)
-    fatal("Archive::children failed: " + toString(std::move(Err)));
+    fatal(MB.getBufferIdentifier() + ": Archive::children failed: " +
+          toString(std::move(Err)));
----------------
grimar wrote:
> This looks was not covered by testcase, just like 2 messages above btw,
> also it has uppercase message while we usually do use lowercase always I believe.
Yep, but it wasn't covered originally as well and you have to use binary file to cover this. 


Repository:
  rL LLVM

https://reviews.llvm.org/D26852





More information about the llvm-commits mailing list