[PATCH] D26616: [Stack Slot Coloring] Skip pseudo debug instructions in removing dead stores

[Krzysztof Parzyszek via llvm-commits]

kparzysz accepted this revision.
kparzysz added a comment.
This revision is now accepted and ready to land.

LGTM with a few minor comments.



================
Comment at: lib/CodeGen/StackSlotColoring.cpp:400
       continue;
+    // Skip the pseudo debugging instructions between a load and store
+    while ((NextMI != E) && NextMI->isDebugValue()) {
----------------
I suggest changing it to "... debug pseudo instructions ...".  Also, add a period at the end of the sentence.


================
Comment at: lib/CodeGen/StackSlotColoring.cpp:401
+    // Skip the pseudo debugging instructions between a load and store
+    while ((NextMI != E) && NextMI->isDebugValue()) {
+        ++NextMI;
----------------
The parentheses around != are not necessary.


================
Comment at: lib/CodeGen/StackSlotColoring.cpp:403
+        ++NextMI;
+        ++I;
+    }
----------------
The indent it too large: should be 2 columns.


Repository:
  rL LLVM

https://reviews.llvm.org/D26616