[PATCH] D26224: NewGVN

[Davide Italiano via llvm-commits]

davide added inline comments.


================
Comment at: include/llvm/Transforms/Scalar/GVNExpression.h:221
+};
+class CallExpression final : public BasicExpression {
+private:
----------------
mehdi_amini wrote:
> `final` does not seem applied equally everywhere, for instance why isn't `LoadExpression` marked final as well?
Just an oversight. Fixed (also in other places).


================
Comment at: include/llvm/Transforms/Scalar/GVNExpression.h:241
+
+  virtual ~CallExpression() {}
+
----------------
mehdi_amini wrote:
> `= default;` (check the others)
I converted all of them, please let me know if I missed something


https://reviews.llvm.org/D26224