[PATCH] D26367: Fix DAGCombiner match

Evgeny Stupachenko via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 17 16:58:28 PST 2016


evstupac added a comment.

>> This LGTM but I think we should probably add tests for other targets as well.

There are similar tests on ARM only. When I tried to extend them I've got the following:

  ldrb r12, [lr, r12]!
  ldrb lr, [lr, #1]

Instead of 1 ldrh.

I'm not sure what is more profitable for ARM and which -mtriple/-mcpu is better. So I'd better leave the test inserting for ARM guys.


Repository:
  rL LLVM

https://reviews.llvm.org/D26367





More information about the llvm-commits mailing list