[PATCH] D26632: [sanitizer] Track architecture and UUID of modules in LoadedModule

[Anna Zaks via llvm-commits]

zaks.anna added a comment.

Could you add a test at least for the architecture or will you be testing this in subsequent patches?



================
Comment at: lib/sanitizer_common/sanitizer_procmaps.h:40
+            char filename[], uptr filename_size, uptr *protection) {
+    return Next(start, end, offset, filename, filename_size, nullptr, nullptr,
+         protection);
----------------
Maybe use default arguments here?


================
Comment at: lib/sanitizer_common/sanitizer_procmaps_freebsd.cc:53
                                char filename[], uptr filename_size,
-                               uptr *protection) {
+                               ModuleArch *arch, u8 *uuid, uptr *protection) {
   char *last = proc_self_maps_.data + proc_self_maps_.len;
----------------
It would be good to add asserts saying that support for passing non-null arch and uuid is not implemented for freebsd and linux.


Repository:
  rL LLVM

https://reviews.llvm.org/D26632