[PATCH] D26805: [XRay][AArch64] Implemented a test for the compile-time sleds emitted, and fixed a bug in the jump instruction

[Dean Michael Berris via llvm-commits]

dberris requested changes to this revision.
dberris added inline comments.
This revision now requires changes to proceed.


================
Comment at: lib/Target/AArch64/AArch64AsmPrinter.cpp:228
+  // including the current instruction.
+  EmitToStreamer(*OutStreamer, MCInstBuilder(AArch64::B).addImm(32 >> 2));
 
----------------
Why not just write out the actual number of instructions? i.e. why not just: `.addImm(8)` ?


================
Comment at: test/CodeGen/AArch64/xray-attribute-instrumentation.ll:26
+; CHECK-NEXT:  ret
+}
----------------
You might want to make sure that the xray_instr_map section is written out and that you're seeing the references to the correct labels?


https://reviews.llvm.org/D26805