[PATCH] D26734: [ELF] Don't replace path separators on *NIX

[Davide Italiano via llvm-commits]

davide added inline comments.


================
Comment at: lld/trunk/lib/Core/Reproduce.cpp:56
 static void convertToUnixPathSeparator(SmallString<128> &Path) {
+#ifdef LLVM_ON_WIN32
   std::replace(Path.begin(), Path.end(), '\\', '/');
----------------
davide wrote:
> ruiu wrote:
> > filcab wrote:
> > > Nit: How about `if (LLVM_ON_WIN32)`?
> > > It would force you to always be able to compile the code :-)
> > Is that a common practice? I believe for #define'd macros, we usually use #ifdef.
> Probably, but we should change also in the Archiver at that point.
Just checked, and noticed we're inconsistent here.

```
[davide at cupiditate lib]$ grep -R 'if LLVM_ON_WIN32' * | wc -l
8
[davide at cupiditate lib]$ grep -R 'ifdef LLVM_ON_WIN32' * | wc -l
29
```
So, Filipe, you prefer the other spelling? If so, I can change, but I'd rather change it everywhere.


Repository:
  rL LLVM

https://reviews.llvm.org/D26734