[PATCH] D26677: [ARM] GlobalISel: Select add i32, i32

Tim Northover via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 17 12:57:50 PST 2016


t.p.northover added inline comments.


================
Comment at: lib/CodeGen/GlobalISel/InstructionSelector.cpp:46
 
+    // Predicate operands and optional defs don't need to be constrained.
+    MCOperandInfo OpInfo = I.getDesc().OpInfo[OpI];
----------------
rovka wrote:
> I'm not 100% sure that this is true in the general case. Thoughts?
Seems a bit iffy. What was triggering it in ARM?


================
Comment at: lib/Target/ARM/ARMRegisterBankInfo.cpp:115
+
+  llvm_unreachable("Unsupported opcode");
+}
----------------
You'll probably want this to be "return false" if you intend to use the SDAG fallback in your testing (and similarly for some other assertions).


https://reviews.llvm.org/D26677





More information about the llvm-commits mailing list