[PATCH] D26083: [LV] Scalarize operands of predicated instructions

Michael Kuperstein via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 17 11:37:04 PST 2016


mkuper added a comment.

I'm not a fan of (1) - I don't think specifying the vectorization factor manually should mean that you're uninterested in all other cost-model considerations.

Regarding (2), I'm not sure what's worse - knob proliferation, or not having target-independent tests. That is, one knob is fine, but I wouldn't want to add a knob for every cost-model-dependent decision.
Maybe we can have a catch-all knob that basically says "use the default TTI instead of the current target's"? Does that even make sense?


https://reviews.llvm.org/D26083





More information about the llvm-commits mailing list