[PATCH] D26792: [ELF] Convert GnuHashTableSection to input section

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 17 09:28:04 PST 2016


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/Writer.cpp:951-952
 
-  // Dynamic section must be the last one in this list.
+  // Dynamic section must be the last one in this list and dynamic
+  // symbol table section (DynSymTab) must be the first one.
   finalizeSynthetic<ELFT>(
----------------
Thank you for updating the comment.


Repository:
  rL LLVM

https://reviews.llvm.org/D26792





More information about the llvm-commits mailing list