[PATCH] D26795: [ELF] Better error reporting for linker scripts

[Eugene Leviant via llvm-commits]

evgeny777 added inline comments.


================
Comment at: ELF/LinkerScript.cpp:1140
+      error(Location + Line);
+      error(Location + std::string(ErrLoc.second, ' ') + "^");
+      break;
----------------
grimar wrote:
> In one of my latest patches I found that it is confusing to have multiple lines in output that are starting from "error: xxx".
> I think we should not call error() for more than a single error at once.
Here multiple lines are used to highlight error position, which might be useful, especially when you run linker from command line. I would keep this bearing in mind that we already have tests for it.


Repository:
  rL LLVM

https://reviews.llvm.org/D26795