[PATCH] D26653: [compiler-rt] Support building builtins for a single target

Petr Hosek via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 16 17:22:19 PST 2016


phosek added inline comments.


================
Comment at: cmake/Modules/CompilerRTUtils.cmake:249
 
   string(REPLACE "-" ";" TARGET_TRIPLE_LIST ${COMPILER_RT_DEFAULT_TARGET_TRIPLE})
   list(GET TARGET_TRIPLE_LIST 0 COMPILER_RT_DEFAULT_TARGET_ARCH)
----------------
I'm not a big fan of the triple parsing business done in CMake, we should probably use the triple directly everywhere without interpreting its content, but that's something that should be done separately as it'll likely require multiple changes.


Repository:
  rL LLVM

https://reviews.llvm.org/D26653





More information about the llvm-commits mailing list