[PATCH] D22295: Introduce GlobalSplit pass.

[Evgeniy Stepanov via llvm-commits]

eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.

LGTM
Please add a FIXME to preserve/update debug metadata.



================
Comment at: llvm/lib/Transforms/IPO/GlobalSplit.cpp:82
+    // Rebuild type metadata, adjusting by the split offset.
+    for (MDNode *Type : Types) {
+      uint64_t ByteOffset = cast<ConstantInt>(
----------------
pcc wrote:
> eugenis wrote:
> > This is N^2.
> > N is probably very small in practice, but I guess there can be outliers. Consider switching to an NlogN implementation?
> On my machine this pass takes 0.4 seconds to run during an LTO link of chrome. So I don't think it's worth making major changes for performance here.
OK, that's reasonable.


https://reviews.llvm.org/D22295