[PATCH] D26710: [LLVM] Fix some Clang-tidy modernize-use-default, modernize-use-equals-delete and Include What You Use warnings; other minor fixes
Eugene Zelenko via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 16 10:29:33 PST 2016
Eugene.Zelenko added inline comments.
================
Comment at: include/llvm/IR/DebugInfoMetadata.h:137
}
+
bool operator==(const iterator &X) const { return I == X.I; }
----------------
mehdi_amini wrote:
> What the rule for deciding on empty line or not? (The two operators below are not separated for instance).
>
> It also does not seem part of the clang-tidy kind of changes.
I think it's adding empty lines make code more comprehensible: it's much easier to see boundaries of multi-line functions/methods.
Repository:
rL LLVM
https://reviews.llvm.org/D26710
More information about the llvm-commits
mailing list