[PATCH] D26604: [ELF] - Added support for extern "c++" local symbols in version script.

[Rui Ueyama via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/SymbolTable.cpp:721
+    for (SymbolVersion Sym : V.Locals)
+      assignVersion(Sym, VER_NDX_LOCAL, "'local'");
   }
----------------
grimar wrote:
> ruiu wrote:
> > Is there any reason to add single quotes? Please remove them because `V.Name` doesn't contain such quotes.
> Lets add them for V.Name ? That is consistent with other messages we added recently
Well, what you pass here is a version name, and that's the right thing to do. If you want to add single quotes, do it in the string in error().


https://reviews.llvm.org/D26604