[PATCH] D26604: [ELF] - Added support for extern "c++" local symbols in version script.
Rui Ueyama via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 16 09:28:18 PST 2016
ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: ELF/SymbolTable.cpp:721
+ for (SymbolVersion Sym : V.Locals)
+ assignVersion(Sym, VER_NDX_LOCAL, "'local'");
}
----------------
Is there any reason to add single quotes? Please remove them because `V.Name` doesn't contain such quotes.
https://reviews.llvm.org/D26604
More information about the llvm-commits
mailing list