[PATCH] D26748: [ARM] Relax restriction on variadic functions for tailcall optimization

[Oliver Stannard via llvm-commits]

olista01 added a comment.

The change itself looks fine, I have a few suggestions for testing:

The test is checking the APCS ABI, could you add some extra RUN lines to check the newer AAPCS ABI? In particular, v_caller_ints2 will not be tail-callable in AAPCS because i64s must be in an even-odd register pair, so the last argument will go on the stack.

I'd also suggest adding some tests using doubles, and using the arm_aapcs_vfpcc calling convention, as doubles get treated differently for variadic and non-variadic calls.


https://reviews.llvm.org/D26748