[PATCH] D26181: RegCall - Handling v64i1 in 32/64 bit target

[Oren Ben Simhon via llvm-commits]

oren_ben_simhon marked an inline comment as done.
oren_ben_simhon added inline comments.


================
Comment at: lib/Target/X86/X86CallingConv.td:91
+    // TODO: Handle the case of mask types (v*i1)
+    CCIfType<[v8i1, v16i1, v32i1], CCCustom<"CC_X86_RegCall_Error">>,
+
----------------
delena wrote:
> oren_ben_simhon wrote:
> > delena wrote:
> > > do you implement CC_X86_RegCall_Error for the types that will come in the next commit?
> > Yes
> I think we can stay with TODO comment till the next commit and remove CC_X86_RegCall_Error
The custom function was introduced in the previous commit and was requested by other reviewers.
The community wants a user (of this version) to have an error message if it uses something that is not yet supported.
I agree with this approach and prefer to leave this as is.



Repository:
  rL LLVM

https://reviews.llvm.org/D26181