[PATCH] D26181: RegCall - Handling v64i1 in 32/64 bit target

[Elena Demikhovsky via llvm-commits]

delena added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:2410
+  // Read a 32 bit value from the register
+  if (nullptr == InFlag) {
+    // When no physical register is present,
----------------
oren_ben_simhon wrote:
> delena wrote:
> > you can combine this "if" with the previous one, right?
> I can do so but it will require duplication of the following lines:
>   // Convert the i32 type into v32i1 type
>   Lo = DAG.getBitcast(MVT::v32i1, ArgValue);
> ...
>   // Convert the i32 type into v32i1 type
>   Hi = DAG.getBitcast(MVT::v32i1, ArgValue);
> 
> So i prefered to seprate it into two different if statements.
Use ArgValueLo and ArgValueHi inside if-else blocks


Repository:
  rL LLVM

https://reviews.llvm.org/D26181