[PATCH] D26224: NewGVN

[Mehdi AMINI via llvm-commits]

mehdi_amini added a comment.

Great to see this finally come upstream! Thanks for driving this :)

(Just two quick comments inline while I'm here)



================
Comment at: include/llvm/Transforms/Scalar/GVNExpression.h:221
+};
+class CallExpression final : public BasicExpression {
+private:
----------------
`final` does not seem applied equally everywhere, for instance why isn't `LoadExpression` marked final as well?


================
Comment at: include/llvm/Transforms/Scalar/GVNExpression.h:241
+
+  virtual ~CallExpression() {}
+
----------------
`= default;` (check the others)


https://reviews.llvm.org/D26224