[PATCH] D26710: [LLVM] Fix some Clang-tidy modernize-use-default, modernize-use-equals-delete and Include What You Use warnings; other minor fixes

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 15 21:42:46 PST 2016


mehdi_amini added inline comments.


================
Comment at: include/llvm/IR/DebugInfoMetadata.h:137
     }
+
     bool operator==(const iterator &X) const { return I == X.I; }
----------------
What the rule for deciding on empty line or not? (The two operators below are not separated for instance).

It also does not seem part of the clang-tidy kind of changes.


================
Comment at: include/llvm/Support/CommandLine.h:487
 public:
-  OptionValueCopy() : Valid(false) {}
+  OptionValueCopy() = default;
 
----------------
Is there a clang-tidy check that does that? That's neat!


Repository:
  rL LLVM

https://reviews.llvm.org/D26710





More information about the llvm-commits mailing list