[PATCH] D26708: Fix -f[no-]reciprocal-math -ffast-math interaction, including LTO

Hal Finkel via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 15 15:57:55 PST 2016


hfinkel added a comment.

In https://reviews.llvm.org/D26708#596623, @wristow wrote:

> In https://reviews.llvm.org/D26708#596608, @majnemer wrote:
>
> > This change seems wrong.  Our IR defines `fast` as implying `arcp`: http://llvm.org/docs/LangRef.html#fast-math-flags
>
>
> So the change to make `-ffast-math -fno-reciprocal-math` work should be (a) remove the `fast` flag, and (b) add all the other ones (except `arcp`) to each relevant place?


We might reconsider having 'fast' imply all of the other flags. I believe this was a suboptimal design choice, and so long as someone is willing to do the work to separate out the various semantic requirements, we should allow that work to proceed. We should discuss this on llvm-dev first, however.


https://reviews.llvm.org/D26708





More information about the llvm-commits mailing list