[PATCH] D26699: [BypassSlowDivision] Handle division by constant numerators properly.

[Artem Belevich via llvm-commits]

tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.

Comment nit. OK otherwise.



================
Comment at: llvm/lib/Transforms/Utils/BypassSlowDivision.cpp:160
+
+  // We bailed out above that the divisor is not a constant, but the dividend
+  // may still be a constant.  Set OrV to our non-constant operands OR'ed
----------------
jlebar wrote:
> tra wrote:
> > This does not parse.
> > Perhaps it was meant to be "We ensured above" or "We bailed out above if divisor *was* constant".
> Fixed, thanks.
Now it parses, but still does not seem to match the code.
We bail out if divisor *is* constant.


https://reviews.llvm.org/D26699