[PATCH] D26172: Add llvm-objdump support for wasm file format

[Michael Spencer via llvm-commits]

Bigcheese added a comment.

I'm taking a look. First thing I noticed is that it parses up front on creation. I'm not familiar with the wasm binary format, but generally we try to be as lazy as possible with this API.



================
Comment at: lib/Object/WasmObjectFile.cpp:22-24
+  std::unique_ptr<WasmObjectFile> ObjectFile;
+
+  ObjectFile.reset(new WasmObjectFile(Buffer, Err));
----------------
```
auto ObjectFile = llvm::make_unique<WasmObjectFile>(Buffer, Err));
```


https://reviews.llvm.org/D26172