[PATCH] D26671: Export llvm::APFloatBase static fltSemantics data members in extract_symbols.py

[Stephan Bergmann via llvm-commits]

sberg added a comment.

The plugin doesn't itself access those members at all; it is inline functions in the LLVM/Clang include files that cause the access.

At first I thought such data access across DLL/EXE boundaries wouldn't work at all with MSCV, and that I'd need to replace those exposed data members with getter functions across all of LLVM.  Then I found it did work and vaguely remembered there'd been some MSVC improvements in that area in the past years.  But probably it just happened to work by luck then.

Doing the replacement with getters for these specific members didn't appear to be that much work when I initially looked, so when you say that would overall be considered beneficial, anyway, I'll see to do that instead.


https://reviews.llvm.org/D26671