[PATCH] D26673: [AArch64] Add support for Qualcomm's Falkor CPU
Matthias Braun via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 15 12:05:01 PST 2016
MatzeB accepted this revision.
MatzeB added a reviewer: MatzeB.
MatzeB added a comment.
LGTM
================
Comment at: unittests/Support/TargetParserTest.cpp:545-548
const char *CPU[] = {"cortex-a35", "cortex-a53", "cortex-a57",
"cortex-a72", "cortex-a73", "cyclone",
- "exynos-m1", "exynos-m2", "kryo",
+ "exynos-m1", "exynos-m2", "falkor", "kryo",
"vulcan"};
----------------
Maybe reformat this list to have 1 name per line. This makes it friendlier for merging/cherry picking. (I also like the fact that I can easily sort such a list of names alphabetically in my editor).
https://reviews.llvm.org/D26673
More information about the llvm-commits
mailing list