[PATCH] D25438: [mips] Fix Mips MSA instrinsics

Vasileios Kalintiris via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 15 11:28:53 PST 2016


vkalintiris added inline comments.


================
Comment at: lib/Target/Mips/MipsSEISelLowering.cpp:2289
+  if (Subtarget.isABI_N64())
+    Offset = DAG.getSExtOrTrunc(Offset, DL, PtrTy);
+
----------------
Is there any scenario where we might need to truncate the offset here? It seems to me that we only care for the extension of the offset type with an IDS::SIGN_EXTEND node. Similarly for the lowerMSAStoreIntr below.


https://reviews.llvm.org/D25438





More information about the llvm-commits mailing list