[PATCH] D26183: [compiler-rt] builtins: Allow building windows arm functions for mingw

[Saleem Abdulrasool via llvm-commits]

compnerd requested changes to this revision.
compnerd added a comment.
This revision now requires changes to proceed.

I think its nicer to split out the conversion functions for windows into a separate file that can be conditionally built.



================
Comment at: lib/builtins/arm/aeabi_idivmod.S:20
+#define __aeabi_idivmod __rt_sdiv
+#endif
+
----------------
Id rather sink this around the `DEFINE_COMPILERRT_FUNCTION`.  There is a single use, and that makes it more apparent that we are trying to rename the function.


================
Comment at: lib/builtins/arm/aeabi_ldivmod.S:21
+#define __aeabi_ldivmod __rt_sdiv64
+#endif
+
----------------
Similar.


https://reviews.llvm.org/D26183