[PATCH] D26645: Add a file magic for CL.exe's object file created with /GL.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 14 17:04:11 PST 2016


ruiu added inline comments.


================
Comment at: lib/Support/Path.cpp:998
+          return file_magic::coff_object;
+        if (memcmp(Start, COFF::ClGlObjMagic, sizeof(COFF::BigObjMagic)) == 0)
+          return file_magic::coff_cl_gl_object;
----------------
pcc wrote:
> It doesn't really matter, but `sizeof(COFF::ClGlObjMagic)` here.
I'd prefer the current code for consistency with the code above.


https://reviews.llvm.org/D26645





More information about the llvm-commits mailing list