[PATCH] D26524: [AArch64] Sink sext when foldable in user GEPs

[Chad Rosier via llvm-commits]

mcrosier added inline comments.


================
Comment at: lib/Target/AArch64/AArch64AddressTypePromotion.cpp:131
 
   /// Merge redundant sign extension operations in common dominator.
   void mergeSExts(ValueToInsts &ValToSExtendedUses,
----------------
It would probably be a good idea to rename this method and update the comment accordingly now that this logic both hoists common sexts and sinks foldable sexts.  Unfortunately, I can't come up with a good name off the top of my head.


================
Comment at: test/CodeGen/AArch64/aarch64-address-type-promotion-sink.ll:246
+if.then:
+; CHECK-LABEL: %if.then
+; CHECK-NOT: sxtw x{{[0-9]+}}, w{{[0-9]+}}
----------------
I don't think you're using the CHECK-LABEL directive the way it is intended here (i.e., the %if.then label isn't unique to this file).  I suggest using a regular CHECK. 


https://reviews.llvm.org/D26524