[PATCH] D26601: [CMake] Minor cleanup to Xcode toolchain generation

[Chris Bieneman via llvm-commits]

beanz added a comment.

Removing the dead code is fine. Really not a fan of removing PlistBuddy.

Generally I'm not sure supporting building OS X binaries on non-Apple systems is a good idea, and using echo like this is less maintainable than using a tool that actually understands plists.

If you're cross building your Darwin compiler (and I *really* don't want to know if you are or how you're doing it... because lawyers). It seems to me that constructing the toolchain plist is something you might want to handle outside the LLVM build system.


Repository:
  rL LLVM

https://reviews.llvm.org/D26601