[PATCH] D26634: Make block placement determinisatic

Daniel Berlin via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 14 14:15:21 PST 2016


If you do 1, just use setvector/smallsetvector


On Mon, Nov 14, 2016 at 2:06 PM, David Li via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> davidxl added inline comments.
>
>
> ================
> Comment at: lib/CodeGen/MachineBlockPlacement.cpp:1498
> +   // matching clang binary in bootstrap build.
> +   for (MachineBasicBlock &LoopBB : *F)
> +     if (LoopBlockSet.count(&LoopBB))
> ----------------
> This fix has compile time implication. Two alternatives:
> 1) make collectLoopBlockSet to also compute a vector of blocks in fixed
> order
> or
> 2) change BlockFilterSet to be a set of integers where the integer is
> MBB's unique id: getNumber()
>
>
> https://reviews.llvm.org/D26634
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161114/71a63a18/attachment.html>


More information about the llvm-commits mailing list