[PATCH] D26230: [AddressSanitizer] Add support for (constant-)masked loads and stores.

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 14 12:48:08 PST 2016


vitalybuka accepted this revision.
vitalybuka added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:1064
+          *Alignment = 1; // No alignment guarantees. We probably got Undef
+        if (MaybeMask)
+          *MaybeMask = CI->getOperand(2 + OpOffset);
----------------
You don't call this with nullptr, so for consistency with other output arguments i'd remove "if (MaybeMask)" check


https://reviews.llvm.org/D26230





More information about the llvm-commits mailing list