[PATCH] D25966: [AArch64] Lower multiplication by a constant int to shl+add+shl
Gerolf Hoflehner via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 14 12:09:03 PST 2016
Gerolf added a comment.
Thanks for following up!
LGTM
================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:7650
+ // Use ConstantA instead of ConstValue to support both shift+add/sub and
+ // shift+add+shift.
+ APInt ConstantA = ConstValue.ashr(TrailingZeroes);
----------------
CAMinus1 is consistent with the comment. Perhaps ConstantAMinus1 would be even more clear.
Repository:
rL LLVM
https://reviews.llvm.org/D25966
More information about the llvm-commits
mailing list