[PATCH] D26593: [X86][GlobalISel] Add minimal call lowering support to the IRTranslator

[Quentin Colombet via llvm-commits]

> On Nov 13, 2016, at 9:37 PM, Mehdi AMINI <mehdi.amini at apple.com> wrote:
> 
> mehdi_amini added a comment.
> 
> In https://reviews.llvm.org/D26593#594014, @hfinkel wrote:
> 
>> In https://reviews.llvm.org/D26593#593918, @davide wrote:
>> 
>>> Picking this one (but the same applies to the ARM global isel skeleton commit).
>>> I'm a little bit concerned to see various targets moving to global isel without proper scrutiny, as already pointed out by @echristo on llvm-dev. Don't get me wrong, I'm personally very excited about the whole idea, and it's likely that my organization will put some resources on it in the foreseeable future, but I would be less worried if Eric's concerns are addressed before moving forward.
>> 
>> 
>> Frankly, I see no better way to give GlobalISel the scrutiny it requires than by starting to port backends to it. We just need to have the right mindset about it.
> 
> 
> There is always a tradeoff though: it makes harder to change pieces of the design as you increase the number of client of a framework/API. So it has to be carefully planned. But the core devs of GlobalISel are the best people to evaluate this tradeoff!

Thanks Mehdi for bringing that up.

Yeah, we encourage GlobalISel adoption with more targets to help asserting the robustness of the design and the flexibility of the APIs, but we may break the APIs, so consider the support experimental at this point. 

Cheers,
-Quentin
> 
> 
> Repository:
>  rL LLVM
> 
> https://reviews.llvm.org/D26593
> 
> 
>