[PATCH] D26622: Linker: Remove unnecessary call to copyMetadata in IRLinker::linkGlobalVariable.

[Adrian Prantl via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Thanks for the quick turnaround. One question inline, but otherwise this looks good.



================
Comment at: llvm/lib/Linker/IRMover.cpp:953
 void IRLinker::linkGlobalVariable(GlobalVariable &Dst, GlobalVariable &Src) {
-  Dst.copyMetadata(&Src, 0);
-
----------------
So, is the metadata attached to Dst always identical to the one in Src, or could there be a situation where one is more complete / otherwise better than the other?


https://reviews.llvm.org/D26622