[PATCH] D26536: [PPC] Add intrinsic mapping to the xscvhpsp instruction (VSX Scalar Convert Half-Precision to Single-Precision)

[Sean Fertile via llvm-commits]

sfertile marked an inline comment as done.
sfertile added inline comments.


================
Comment at: lib/Target/PowerPC/PPCInstrVSX.td:2147
+  def : Pat<(v4f32 (int_ppc_vsx_xvcvhpsp v8i16:$A)),
+            (XVCVHPSP (COPY_TO_REGCLASS $A, VSRC))>;
 
----------------
nemanjai wrote:
> I am slightly surprised that tblgen is able to infer all the types for this output pattern. However, can you please explicitly specify the output type, if for no other reason but consistency with the rest of the anonymous patterns in this file. Something like:
> `(v4f32 (XVCVHPSP (COPY_TO_REGCLASS $A, VSRC)))`
Fixed


Repository:
  rL LLVM

https://reviews.llvm.org/D26536