[PATCH] D26597: [XRay][compiler-rt] Disable XRay instrumentation of the XRay runtime.
Serge Rogatch via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 14 09:38:25 PST 2016
rSerge added inline comments.
================
Comment at: cmake/builtin-config-ix.cmake:14
builtin_check_c_compiler_flag(-ffreestanding COMPILER_RT_HAS_FREESTANDING_FLAG)
+builtin_check_c_compiler_flag(-fxray-instrument COMPILER_RT_HAS_XRAY_COMPILER_FLAG)
----------------
Is this a check that the host compiler (not the one being compiled) supports XRay instrumentation? A comment would help.
================
Comment at: lib/xray/xray_arm.cc:74-76
inline static bool patchSled(const bool Enable, const uint32_t FuncId,
- const XRaySledEntry &Sled, void (*TracingHook)()) {
+ const XRaySledEntry &Sled,
+ void (*TracingHook)()) XRAY_NEVER_INSTRUMENT {
----------------
The function header could take only 2 lines if the second line starts after a single indentation (2 spaces). Is it a LLVM requirement to indent so much when a function header doesn't fit 1 line?
https://reviews.llvm.org/D26597
More information about the llvm-commits
mailing list