[PATCH] D26402: [ThinLTO] Make inline assembly handling more efficient in summary

[Mehdi AMINI via llvm-commits]

mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.

LGTM.

In https://reviews.llvm.org/D26402#594367, @tejohnson wrote:

> On Sat, Nov 12, 2016 at 10:04 PM, Mehdi Amini <mehdi.amini at apple.com> wrote:
>
> > Not sure about 1: you can’t assume of whatever specific meaning is attached to a section in general.
>
> Meaning we wouldn't necessarily be able to import as a copy? I was basing this suggestion on the discussion we had for the patch that initially limited importing of global values with sections (https://reviews.llvm.org/D18298), which is when the FIXME about importing these as copies was added.


Yes, I'm not sure it is always legal to copy. LangRef is fairly vague with sections at the IR level though. We can always try and see what breaks in practice :)

>> Also, if you still want to keep the separated flag, then MayReferenceNoRename isn’t great: it should be targeting the case 2 you mentioned exclusively, so it should be something like HasInlineASMReferencingInternal or something like that.
> 
> Ok, will update the name. Although we don't know for sure whether the inline asm references a local, so perhaps HasInlineASMMaybeReferencingInternal. 
>  A mouthful, but more descriptive.

Right, I was already finding my original suggestion long, apparently you can do better :)


https://reviews.llvm.org/D26402