[PATCH] D26078: [cmake] Temporarily revert enforcement of minimum GCC version increase

[Aaron Ballman via llvm-commits]

On Thu, Nov 10, 2016 at 4:56 PM, Teresa Johnson <tejohnson at google.com> wrote:
> Great, thanks for following up on that! Teresa

I have reverted the change in r286822, so we're back to checking for
GCC 4.8 now. Thank you (everyone) for working on this!

~Aaron

>
>
> On Thu, Nov 10, 2016, 1:54 PM Aaron Ballman <aaron.ballman at gmail.com> wrote:
>>
>> On Fri, Oct 28, 2016 at 11:46 AM, Aaron Ballman <aaron.ballman at gmail.com>
>> wrote:
>> > On Fri, Oct 28, 2016 at 11:43 AM, Teresa Johnson <tejohnson at google.com>
>> > wrote:
>> >>
>> >> Aaron, will you be able to revert this change when the bot is upgraded?
>> >> Tanya - any ETA? Or one of you can let me know and I will revert it.
>> >
>> > I'm happy to revert once the bot is upgraded.
>>
>> To follow up on this -- Tanya fixed the documentation bot today so
>> that it's no longer on GCC 4.7. If the bot works properly during its
>> daily build cycle (which it is expected to), I will update the cmake
>> files to bring back the GCC 4.8 version checking tomorrow morning.
>>
>> Thanks!
>>
>> ~Aaron
>>
>> >
>> > ~Aaron
>> >
>> >>
>> >> Thanks,
>> >> Teresa
>> >>
>> >> On Fri, Oct 28, 2016 at 8:39 AM, Teresa Johnson <tejohnson at google.com>
>> >> wrote:
>> >>>
>> >>> This revision was automatically updated to reflect the committed
>> >>> changes.
>> >>> Closed by commit rL285406: [cmake] Temporarily revert enforcement of
>> >>> minimum GCC version increase (authored by tejohnson).
>> >>>
>> >>> Changed prior to commit:
>> >>>   https://reviews.llvm.org/D26078?vs=76198&id=76200#toc
>> >>>
>> >>> Repository:
>> >>>   rL LLVM
>> >>>
>> >>> https://reviews.llvm.org/D26078
>> >>>
>> >>> Files:
>> >>>   llvm/trunk/cmake/modules/CheckCompilerVersion.cmake
>> >>>
>> >>>
>> >>> Index: llvm/trunk/cmake/modules/CheckCompilerVersion.cmake
>> >>> ===================================================================
>> >>> --- llvm/trunk/cmake/modules/CheckCompilerVersion.cmake
>> >>> +++ llvm/trunk/cmake/modules/CheckCompilerVersion.cmake
>> >>> @@ -8,8 +8,9 @@
>> >>>
>> >>>    if(NOT LLVM_FORCE_USE_OLD_TOOLCHAIN)
>> >>>      if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
>> >>> -      if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 4.8)
>> >>> -        message(FATAL_ERROR "Host GCC version must be at least 4.8!")
>> >>> +      # FIXME: Change this to 4.8 once documentation builder bot is
>> >>> upgraded
>> >>> +      if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 4.7)
>> >>> +        message(FATAL_ERROR "Host GCC version must be at least 4.7!")
>> >>>        endif()
>> >>>      elseif(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
>> >>>        if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 3.1)
>> >>> @@ -35,7 +36,8 @@
>> >>>  int main() { return (float)x; }"
>> >>>            LLVM_NO_OLD_LIBSTDCXX)
>> >>>          if(NOT LLVM_NO_OLD_LIBSTDCXX)
>> >>> -          message(FATAL_ERROR "Host Clang must be able to find
>> >>> libstdc++4.8 or newer!")
>> >>> +          # FIXME: Change this to 4.8 once documentation builder bot
>> >>> is upgraded
>> >>> +          message(FATAL_ERROR "Host Clang must be able to find
>> >>> libstdc++4.7 or newer!")
>> >>>          endif()
>> >>>          set(CMAKE_REQUIRED_FLAGS ${OLD_CMAKE_REQUIRED_FLAGS})
>> >>>          set(CMAKE_REQUIRED_LIBRARIES ${OLD_CMAKE_REQUIRED_LIBRARIES})
>> >>>
>> >>>
>> >>
>> >>
>> >>
>> >> --
>> >> Teresa Johnson | Software Engineer | tejohnson at google.com |
>> >> 408-460-2413